Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of double negation in Events semantic conventions #3159

Merged
merged 4 commits into from
Feb 15, 2023
Merged

Get rid of double negation in Events semantic conventions #3159

merged 4 commits into from
Feb 15, 2023

Conversation

martinknechtel
Copy link
Contributor

Is that what you intended?

@martinknechtel martinknechtel requested review from a team January 31, 2023 13:09
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jan 31, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@martinknechtel
Copy link
Contributor Author

@scheler FYI

@martinknechtel @yurishkuro
Update specification/logs/semantic_conventions/events.md
313075e 
Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>
scheler
scheler approved these changes Jan 31, 2023
View reviewed changes
Copy link
Contributor

@scheler scheler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@martinknechtel thanks for catching the error.

@MrAlias
Copy link
Contributor

MrAlias commented Feb 2, 2023

@martinknechtel please sign the the CLA so these changes can be considered.

@arminru arminru added the editorial Editorial changes only (typos, changelog, ...). No content-related changes of any kind. label Feb 7, 2023
@github-actions
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Feb 15, 2023
@martinknechtel
Copy link
Contributor Author

@scheler @MrAlias done, can be merged from my perspective

@tigrannajaryan tigrannajaryan changed the title getting rid of double negation Get rid of double negation in Events semantic conventions Feb 15, 2023
@reyang reyang removed the Stale label Feb 15, 2023
@yurishkuro yurishkuro merged commit f39c662 into open-telemetry:main Feb 15, 2023
@martinknechtel martinknechtel deleted the patch-1 branch February 20, 2023 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scheler scheler scheler approved these changes

@yurishkuro yurishkuro yurishkuro approved these changes

@tigrannajaryan tigrannajaryan tigrannajaryan approved these changes

@arminru arminru arminru approved these changes

@reyang reyang reyang approved these changes

Assignees

@yurishkuro yurishkuro

Labels
editorial Editorial changes only (typos, changelog, ...). No content-related changes of any kind.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@martinknechtel @MrAlias @scheler @yurishkuro @tigrannajaryan @arminru @reyang